feat: improve discardcloudservice filter in yurthub component (#1924) #1926
Conversation
huangchenzhao
force-pushed
the
issue1924
branch
2 times, most recently
from
02595c9
to
83bbced
Compare
|
It seems unit tests in 'discardcloudservice filter' should be modified to ensure synchronization with the changed code, I will fix it soon. |
yes, unit tests also should be tuned. |
…rtio#1924) Signed-off-by: Chenzhao Huang <[email protected]>
huangchenzhao
force-pushed
the
issue1924
branch
from
83bbced
to
e651e7d
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1926 +/- ##
==========================================
+ Coverage 52.16% 52.19% +0.02%
==========================================
Files 172 173 +1
Lines 20874 21117 +243
==========================================
+ Hits 10888 11021 +133
- Misses 9018 9120 +102
- Partials 968 976 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fixed unit tests. |
|
/rerun |
2 similar comments
|
/rerun |
|
/rerun |
|
/lgtm |
…rtio#1924) (openyurtio#1926) Signed-off-by: Chenzhao Huang <[email protected]>
What type of PR is this?
What this PR does / why we need it:
have improved discardcloudservice filter in yurthub component
only discarding LoadBalancer service which has annotation
svc.openyurt.io/discard=true, instead of which doesn't haveopenyurt.io/skip-discard=true.Which issue(s) this PR fixes:
Fixes #1924